-
Notifications
You must be signed in to change notification settings - Fork 0
chore: QE testing #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: QE testing #212
Conversation
WalkthroughJira μ΄μ μμ± μν¬νλ‘μ°μμ μμ±λλ μ΄μ νμ μ Taskμμ SubTaskλ‘ λ³κ²½νμ΅λλ€. λ€λ₯Έ νλλ μ²λ¦¬ νλ¦μ λ³κ²½λμ§ μμμ΅λλ€. Changes
Estimated code review effortπ― 1 (Trivial) | β±οΈ ~2 minutes Pre-merge checks and finishing touchesβ Failed checks (1 warning)
β Passed checks (2 passed)
β¨ Finishing touchesπ§ͺ Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and canβt be posted inline due to platform limitations.
β οΈ Outside diff range comments (3)
.github/workflows/create-jira-issue.yml (3)
106-114: Jira issuetype νκΈ° μ€λ₯ κ°λ₯μ±:SubTaskβSub-taskλ‘ κ΅μ²΄ νμJira Cloud/Server κΈ°λ³Έ μ΄μ νμ λͺ μ 보ν΅
Sub-taskμ λλ€.SubTaskλ λ§€μΉ μ€ν¨λ‘ μμ±μ΄ 400 μλ¬λ‘ ν°μ§ μ μμ΅λλ€. νλ‘μ νΈλ³ 컀μ€ν λͺ μ΄ μλλΌλ©΄ μλμ²λΌ κ΅μ νμΈμ. λν κ°λ₯νλ©΄ μ΄λ¦ λμ μ΄μ νμ βIDβ μ¬μ©μ κΆμ₯ν©λλ€.- issuetype: SubTask + issuetype: Sub-taskλμ: μ΄λ¦ λμ νμ IDλ₯Ό μ°κ±°λ,
with:λΈλ‘μparent:μ λ ₯μ μ§μ μ§μ ν΄fieldsμμ‘΄μ±μ μ€μΌ μ μμ΅λλ€.
116-118: λ‘κ·Έ μΆλ ₯ ν€ λΆμΌμΉ:issueparser_parentKeyμ¬μ© νμ
issue-parserμΆλ ₯ ν€ μ λμ¬κ° λΉ μ Έ νμ¬λ λΉ κ°μ΄ μ°ν κ°λ₯μ±μ΄ ν½λλ€.- run: echo "Jira Issue ${{ steps.issue-parser.outputs.parentKey }}/${{ steps.create.outputs.issue }} was created" + run: echo "Jira Issue ${{ steps.issue-parser.outputs.issueparser_parentKey }}/${{ steps.create.outputs.issue }} was created"
151-157: μ΄μ μ λͺ© ν¬λ§· μ€νμ: λ«λ λκ΄νΈ λλ½μλν νμμ΄
[KEY] Titleλ₯λΌλ©΄ λκ΄νΈκ° λ«νμ§ μμμ΅λλ€.- title: '[${{ steps.create.outputs.issue }}/${{ github.event.issue.title }}' + title: '[${{ steps.create.outputs.issue }}] ${{ github.event.issue.title }}'
π§Ή Nitpick comments (3)
.github/workflows/create-jira-issue.yml (3)
135-143: λΈλμΉλͺ κ΅¬μ± κ°μ :#μ¬μ© μ§μ + λ―Έμ¬μ© λ³μslugμ²λ¦¬
#λ Git μ체λ‘λ κ°λ₯νμ§λ§ URL/CLIμμ νΌμ μ μ λ°ν©λλ€. λνslugλ₯Ό κ³μ°ν΄ λκ³ μ¬μ©νμ§ μμ΅λλ€. λ³΄λ€ μμ ν λ€μ΄λ°μΌλ‘ μ 리νμΈμ.- slug=$(echo "$issue_title" | tr '[:upper:]' '[:lower:]' | sed 's/ /-/g' | sed 's/[^a-z0-9\-]//g') + slug=$(echo "$issue_title" | tr '[:upper:]' '[:lower:]' | sed 's/ /-/g' | sed 's/[^a-z0-9\-]//g') ticket_key="${{ steps.create.outputs.issue }}" - branch_name="${ticket_key}-${{ steps.type.outputs.type }}/#${issue_number}" + branch_name="${ticket_key}-${{ steps.type.outputs.type }}/${slug:-issue-${issue_number}}"νΉμ λ¨μν:
- branch_name="${ticket_key}-${{ steps.type.outputs.type }}/#${issue_number}" + branch_name="${ticket_key}-${{ steps.type.outputs.type }}/issue-${issue_number}"
65-69: μ€λ³΅ 체ν¬μμ/λΈλμΉ μ ν μ 리
Checkout main code (ref: develop)ν λ€μ 체ν¬μμ/νμΉνλ λ¨κ³κ° μ€λ³΅μ λλ€. ν λ¨κ³λ‘ ν©μ³ λ¬λ μκ° λ¨μΆνμΈμ.
- μ΅μ A: 첫 체ν¬μμ μμ , λ λ²μ§Έ 체ν¬μμμ
ref: develop+fetch-depth: 0μ§μ νSwitch to developλ¨κ³ μ κ±°.- μ΅μ B: 첫 체ν¬μμλ§ μ μ§νκ³ , λ λ²μ§Έ 체ν¬μμ λ°
Switch to developμ κ±°.Also applies to: 124-133
101-115: μ¬μ κ²μ¦ μΆκ° κΆμ₯:parentKeyλλ½ μ λΉ λ₯Έ μ€ν¨μλΈνμ€ν¬λ λΆλͺ¨ ν€κ° νμμ λλ€. νμκ° κ°μ λͺ» κ°μ Έμ€λ©΄ μμ± λ¨κ³μμ 400μ΄ λ©λλ€. μμ± μ κ°λ¨ν κ°λ μΆκ°λ₯Ό κΆμ₯ν©λλ€.
- name: Create Issue id: create uses: atlassian/gajira-create@v3 + if: ${{ steps.issue-parser.outputs.issueparser_parentKey != '' }} with: project: BOOK issuetype: Sub-task summary: '${{ github.event.issue.title }}' description: '${{ steps.md2jira.outputs.output-text }}' fields: | { "parent": { "key": "${{ steps.issue-parser.outputs.issueparser_parentKey }}" } }λλ λ°λ‘ μμ μ Έ κ°λλ₯Ό μΆκ°:
- name: Validate parent key run: | if [ -z "${{ steps.issue-parser.outputs.issueparser_parentKey }}" ]; then echo "::error::Missing parent issue key (issueparser_parentKey)." exit 1 fi
π Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
π Files selected for processing (1)
.github/workflows/create-jira-issue.yml(1 hunks)
β° Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
π κ΄λ ¨ μ΄μ
π μμ μ ν
π μμ λ΄μ
π§ͺ ν μ€νΈ λ΄μ
π¨ μ€ν¬λ¦°μ· λλ μμ° μμ (μ ν)
β PR 체ν¬λ¦¬μ€νΈ
π¬ μΆκ° μ€λͺ or 리뷰 ν¬μΈνΈ (μ ν)
Summary by CodeRabbit